Conversation
timtreis
added
documentation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 83.95% 84.08% +0.12%
==========================================
Files 8 8
Lines 1839 1841 +2
==========================================
+ Hits 1544 1548 +4
+ Misses 295 293 -2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors random number generation across the test suite by centralizing it through a standardized function and removes unused RNG variables. It also adds a warning when a specified table doesn't annotate the target element and includes various development environment improvements.
- Replaced direct RNG instantiation with centralized
get_standard_RNG()function for consistent test reproducibility - Added warning validation when
table_nameandcolorare specified but the table doesn't annotate the element - Updated development tooling with pixi configuration and GitHub Actions improvements
Reviewed Changes
Copilot reviewed 12 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Replaced global RNG with get_standard_RNG() function to ensure consistent random state initialization |
| tests/pl/test_*.py | Updated all test files to use centralized RNG function and removed unused RNG variables |
| src/spatialdata_plot/pl/utils.py | Added warning when specified table doesn't annotate element and simplified assignment syntax |
| pyproject.toml | Updated development dependencies and added pixi workspace configuration |
| .github/workflows/test.yaml | Migrated to pixi-based testing environment with improved caching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…-specified-table-doesnt-actually-annotate-the-labels-element
timtreis
changed the title
table_name and color are specified but the table doesn't annotate the element
timtreis
changed the title
timtreis
deleted the
bugfix/issue467-no-warning-when-the-manually-specified-table-doesnt-actually-annotate-the-labels-element
branch
Member
|
Cool work! CC @melonora |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.